Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11253 - Cleanup ComplianceViolation behavior to allow Cookie / URI / MultiPart compliance to also receive listener events. #11254

Merged
merged 36 commits into from
Jan 24, 2024
Merged

Issue #11253 - Cleanup ComplianceViolation behavior to allow Cookie / URI / MultiPart compliance to also receive listener events. #11254

merged 36 commits into from
Jan 24, 2024

Commits on Jan 8, 2024

  1. Fixing comments

    @joakime
    joakime committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a125dcf View commit details
    Browse the repository at this point in the history

  2. Adding TODOs about possible HTTP/2 & HTTP/3 violations

    @joakime
    joakime committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0844436 View commit details
    Browse the repository at this point in the history

  3. Adding missing javadoc

    @joakime
    joakime committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    46b3d6a View commit details
    Browse the repository at this point in the history

  4. Issue #11253 - Cleanup ComplianceViolation behavior to allow Cookie /… 

    … URI / MultiPart compliance to also receive listener events.
    @joakime
    joakime committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2167aa5 View commit details
    Browse the repository at this point in the history

  5. Revert change to jetty-logging.properties

    @joakime
    joakime committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b86a415 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Fix javadoc typos

    @joakime
    joakime committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d8b5bb8 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/12.0.x/co… 

    …okie-compliance-logging
    @joakime
    joakime committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c0d0021 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Issue #11253 - Alternate approach with split ComplianceViolation.List… 

    …ener
    @joakime
    joakime committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3818664 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/12.0.x/co… 

    …okie-compliance-logging
    @joakime
    joakime committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ab199ac View commit details
    Browse the repository at this point in the history

  3. Fix HttpParserTest

    @joakime
    joakime committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    20e7e41 View commit details
    Browse the repository at this point in the history

  4. Cleanup implementation

    @joakime
    joakime committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ee568b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Do not use deprecated method in our own code

    @joakime
    joakime committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1e525b8 View commit details
    Browse the repository at this point in the history

  2. Fix ComplianceViolations2616Test failures

    @joakime
    joakime committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c5eda63 View commit details
    Browse the repository at this point in the history

  3. Fixing ee9/ee8 RequestTest

    @joakime
    joakime committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3182982 View commit details
    Browse the repository at this point in the history

  4. Updates from review

    @joakime
    joakime committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f7e3441 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. WIP on cleanup of ComplianceViolation.Listener instantiation

    @gregw
    gregw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    af2ef3c View commit details
    Browse the repository at this point in the history

  2. WIP on cleanup of ComplianceViolation.Listener instantiation 

    removed attribute access in favour of a HttpChannelState field
    @gregw
    gregw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9cc8053 View commit details
    Browse the repository at this point in the history

  3. WIP on cleanup of ComplianceViolation.Listener instantiation 

    removed attribute access in favour of a HttpChannelState field
    @gregw
    gregw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    607934d View commit details
    Browse the repository at this point in the history

  4. WIP on cleanup of ComplianceViolation.Listener instantiation 

    removed attribute access in favour of a HttpChannelState field
    @gregw
    gregw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9a2643a View commit details
    Browse the repository at this point in the history

  5. WIP on cleanup of ComplianceViolation.Listener instantiation 

    removed attribute access in favour of a HttpChannelState field
    @gregw
    gregw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7f1f08b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Merge branch 'jetty-12.0.x' into fix/12.0.x/cookie-compliance-logging2

    @gregw
    gregw committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    3c631fa View commit details
    Browse the repository at this point in the history

  2. javadoc

    @gregw
    gregw committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    3357919 View commit details
    Browse the repository at this point in the history

  3. Store listeners in AbstractConnector

    @gregw
    gregw committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9601204 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Cleanup and reorganization of Proposal 2

    @joakime
    joakime committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    dc5de07 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge branch 'fix/12.0.x/cookie-compliance-logging3' into fix/12.0.x/… 

    …cookie-compliance-logging

# Conflicts:
#	jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/ComplianceViolation.java
    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cf1f776 View commit details
    Browse the repository at this point in the history

  2. updates from review

    @gregw
    gregw committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c266d16 View commit details
    Browse the repository at this point in the history

  3. updates from review

    @gregw
    gregw committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cdf8fcd View commit details
    Browse the repository at this point in the history

  4. Changes from review

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d7ac0d9 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/fix/12.0.x/cookie-compliance-log… 

    …ging' into fix/12.0.x/cookie-compliance-logging

# Conflicts:
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Components.java
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConfiguration.java
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnectionFactory.java
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9c4c264 View commit details
    Browse the repository at this point in the history

  6. Fixing build

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b4f4003 View commit details
    Browse the repository at this point in the history

  7. Revert RequestHandler change

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    823b0a1 View commit details
    Browse the repository at this point in the history

  8. Support ComplianceViolation.Listener in ee10 multipart/form

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    34a67e2 View commit details
    Browse the repository at this point in the history

  9. Correct since versions

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1177674 View commit details
    Browse the repository at this point in the history

  10. Rename HttpChannel.init() to .initialize()

    @joakime
    joakime committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5e275dd View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. avoid double allocation of compliance listener list

    @gregw
    gregw committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    80f8322 View commit details
    Browse the repository at this point in the history

  2. Avoid request specific listener in cookie cache

    @gregw
    gregw committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fdc0cd8 View commit details
    Browse the repository at this point in the history