chore: skip mercurial tests when no hg installed #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very same check is already done in jestChangedFiles.test.ts
thymikee
approved these changes
Apr 19, 2020
SimenB
reviewed
Apr 19, 2020
dubzzz
commented
Apr 20, 2020
SimenB
approved these changes
Apr 21, 2020
dubzzz
commented
Apr 21, 2020
SimenB
reviewed
Apr 21, 2020
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
SimenB
reviewed
Apr 21, 2020
|
@SimenB This time it should be good 👍 Thanks a lot for the quick reviews, it's impressive 😄 |
SimenB
reviewed
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #9840 +/- ##
==========================================
- Coverage 64.52% 64.51% -0.02%
==========================================
Files 290 290
Lines 12325 12325
Branches 3048 3048
==========================================
- Hits 7953 7951 -2
- Misses 3732 3733 +1
- Partials 640 641 +1
Continue to review full report at Codecov.
|
SimenB
reviewed
Apr 21, 2020
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
|
Thanks! |
SimenB
changed the title
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Apr 26, 2020
…pshots * upstream/master: (39 commits) Prints the Symbol name into the error message with a custom asymmetric matcher (jestjs#9888) Show coverage of sources related to tests in changed files (jestjs#9769) fix: don't /// <reference types="jest" /> (jestjs#9875) noCodeFrame respects noStackTrace (jestjs#9866) chore: update example to react-native@0.62 (jestjs#9746) Improve source map handling when instrumenting transformed code (jestjs#9811) Update .vscode/launch.json settings (jestjs#9868) chore: verify all packages have the same engine requirement (jestjs#9871) fix: pass custom cached realpath function to `resolve` (jestjs#9873) chore: mock stealthy-require in tests (jestjs#9855) chore: update resolve (jestjs#9872) chore: run CircleCI on node 14 (jestjs#9870) Add an option to vscode settings to always use workspace TS (jestjs#9869) fix(esm): handle parallel imports (jestjs#9858) chore: run CI on Node 14 (jestjs#9861) feat: add `@jest/globals` package for importing globals explici… (jestjs#9849) chore: bump resolve package (jestjs#9859) chore(runtime): simplify `createJestObjectFor` (jestjs#9857) chore: fix symlink creation failures on windows in tests (jestjs#9852) chore: skip mercurial tests when no hg installed (jestjs#9840) ...
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Apr 26, 2020
…pshots * upstream/master: (39 commits) Prints the Symbol name into the error message with a custom asymmetric matcher (jestjs#9888) Show coverage of sources related to tests in changed files (jestjs#9769) fix: don't /// <reference types="jest" /> (jestjs#9875) noCodeFrame respects noStackTrace (jestjs#9866) chore: update example to react-native@0.62 (jestjs#9746) Improve source map handling when instrumenting transformed code (jestjs#9811) Update .vscode/launch.json settings (jestjs#9868) chore: verify all packages have the same engine requirement (jestjs#9871) fix: pass custom cached realpath function to `resolve` (jestjs#9873) chore: mock stealthy-require in tests (jestjs#9855) chore: update resolve (jestjs#9872) chore: run CircleCI on node 14 (jestjs#9870) Add an option to vscode settings to always use workspace TS (jestjs#9869) fix(esm): handle parallel imports (jestjs#9858) chore: run CI on Node 14 (jestjs#9861) feat: add `@jest/globals` package for importing globals explici… (jestjs#9849) chore: bump resolve package (jestjs#9859) chore(runtime): simplify `createJestObjectFor` (jestjs#9857) chore: fix symlink creation failures on windows in tests (jestjs#9852) chore: skip mercurial tests when no hg installed (jestjs#9840) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DISCLAIMER: Feel free to close this PR if it does not make sense.
When running
yarn test-cion my machine not havinghginstalled, I saw that some tests requiringhgwere explicitely skipped while others were still executed.I just applied what was done in
jestChangedFiles.test.tson another test that needshgto run.Test plan