Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect: Fix edge case in part 19 #8394

Merged

Conversation

pedrottimark
Copy link
Contributor

Summary

Added a missing comment and condition

No update to CHANGELOG.md if we merge it in same batch as #8367

Test plan

Added 1 snapshot

Example picture baseline at left and improved at right

fix-printReceivedConstructorNameNot

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does the opposite (only superclass has a name) already have a test case?

@pedrottimark
Copy link
Contributor Author

Added the missing test and adjusted format to omit gap at left of received class name:

fix-printReceivedConstructorNameNot 2

@codecov-io
Copy link

Codecov Report

Merging #8394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8394      +/-   ##
==========================================
+ Coverage   62.34%   62.35%   +<.01%     
==========================================
  Files         266      266              
  Lines       10738    10736       -2     
  Branches     2612     2611       -1     
==========================================
- Hits         6695     6694       -1     
  Misses       3460     3460              
+ Partials      583      582       -1
Impacted Files Coverage Δ
packages/expect/src/print.ts 97.72% <100%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b8382...024cea0. Read the comment docs.

@jeysal jeysal merged commit ff9985c into jestjs:master Apr 30, 2019
@pedrottimark pedrottimark deleted the fix-printReceivedConstructorNameNot branch May 1, 2019 14:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants