Remove redundant stripAnsi #7833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to wrap a runJust call into stripAnsi since the latter works only with strings. `runJest` returns an object so stripAnsi just passes it along. Materials: - Commit where the code was added in the first place: jestjs@e12cab6#diff-4cf7d6c79ff377b63522b3af20e34e8eR307 - stripAnsi source code: https://github.com/chalk/strip-ansi/blob/097894423fedb6b4dca3005ad45608b893fcdcf8/index.js
thymikee
approved these changes
Feb 8, 2019
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
## Summary It doesn't make sense to wrap a `runJust` call into `stripAnsi` since the latter works only with strings. `runJest` returns an object so stripAnsi just passes it along. Materials: - Commit where the code was added in the first place: jestjs@e12cab6#diff-4cf7d6c79ff377b63522b3af20e34e8eR307 - stripAnsi source code: https://github.com/chalk/strip-ansi/blob/097894423fedb6b4dca3005ad45608b893fcdcf8/index.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It doesn't make sense to wrap a
runJustcall intostripAnsisince the latter works only with strings.runJestreturns an object so stripAnsi just passes it along.Materials: