Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure generated name in config is stable across runs of Jest #7746

Merged
merged 7 commits into from
Jan 29, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 29, 2019

Summary

Fixes #7732 by basically reverting a change within #5862 (a370c21).

Test plan

Restored the tests from the linked commit, and added a new one (minimal config is stable across runs')

Added a new test to check two runs of normalize are stable, plus an e2e test checking name specifically, both for linked config and inline config

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for breaking this

@thymikee
Copy link
Collaborator

The failure is what @cpojer mentioned in #5862 (comment). This PR only fixes the scenario with inline projects config. Ergh

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

:(

Lemme see if I can fix it

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

The test is flaky, passes for me most of the time locally

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

Pushed a new approach closer to what's in master - it adds the path to the config into the generated name of the project

@@ -210,7 +215,7 @@ const groupOptions = (
}),
});

const ensureNoDuplicateConfigs = (parsedConfigs, projects, rootConfigPath) => {
const ensureNoDuplicateConfigs = (parsedConfigs, projects) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE told me this was an unused arg 🤷‍♂️

@SimenB SimenB merged commit 49a69e5 into jestjs:master Jan 29, 2019
@SimenB SimenB deleted the stable-config-name branch January 29, 2019 17:47
@joelgetaction
Copy link

Thanks @SimenB ! Really appreciate the help on this. Is there going to be a 24.0.1 release to incorporate this bug fix since I'd rather not pull latest from master ...

@SimenB
Copy link
Member Author

SimenB commented Feb 5, 2019

8a2ea1e

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest 24 is 67% slower than Jest 23.6.0 on the same test suite
6 participants