Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: goodbye AppVeyor, it was a good ride #7660

Merged
merged 4 commits into from
Mar 19, 2019

Conversation

thymikee
Copy link
Collaborator

Summary

Since we set up Azure Pipelines, we there's no need for AppVeyor now. Farewell!

Test plan

cc @Daniel15, feel free to remove it from your account :)

@thymikee
Copy link
Collaborator Author

ping @Daniel15, would you mind removing Jest from your AppVeyor?

@Daniel15
Copy link
Contributor

Sorry I missed this! Sure, I can do that. Do we really want to delete it, though? Having the historical data can be useful. It might be worth just removing the hook from the Github repo, so that it doesn't perform any new builds?

@thymikee
Copy link
Collaborator Author

Removing the hook would be just enough :)

@Daniel15
Copy link
Contributor

I'd remove it, but I don't have admin access to this repo :(

@thymikee
Copy link
Collaborator Author

@cpojer can you remove the AppVeyor integration in the project settings?

@cpojer
Copy link
Member

cpojer commented Mar 16, 2019

cc @JoelMarcey

@JoelMarcey
Copy link
Contributor

Ok. AppVeyor webhook deleted.

@codecov-io
Copy link

Codecov Report

Merging #7660 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7660      +/-   ##
==========================================
- Coverage   62.28%   62.27%   -0.01%     
==========================================
  Files         264      264              
  Lines       10435    10435              
  Branches     2533     2533              
==========================================
- Hits         6499     6498       -1     
  Misses       3354     3354              
- Partials      582      583       +1
Impacted Files Coverage Δ
packages/jest-core/src/SearchSource.ts 56.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6af3af...08c3e6d. Read the comment docs.

@SimenB SimenB merged commit d8f43f8 into jestjs:master Mar 19, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants