Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom async matcher stack traces #7652

Merged
merged 10 commits into from
Feb 13, 2019
Merged

Commits on Jan 19, 2019

  1. Fix custom async matcher stack trace

    Fixes a bug causing custom async matcher stack traces to be lost. The
    issue was caused by the JestAssertionError being created after the
    promise for the async matcher resolved - by which point the stack
    containing the correct stack trace (pointing to the line where matcher
    was called) has been discarded. The issue was fixed by passing an error
    that is initialized before the promise resolves.
    Don Schrimsher committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    c1a2b77 View commit details
    Browse the repository at this point in the history
  2. Add test for custom async matcher stack trace fix

    Adds a test to verify the async custom matcher stack trace fix.
    Don Schrimsher committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    7f012f9 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    Don Schrimsher committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    a1e1e40 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Merge remote-tracking branch 'upstream/master'

    Don Schrimsher committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    3018bc8 View commit details
    Browse the repository at this point in the history
  2. Use wrap in e2e test for custom matcher stack trace

    Uses the new wrap utility in e2e snapshot for custom
    matcher stack traces.
    Don Schrimsher committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    023f108 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Merge branch 'master' of github.com:facebook/jest

    Don Schrimsher committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    5f91b0f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Use Promise.resolve in expect async matcher tests

    Don Schrimsher committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    f2e50aa View commit details
    Browse the repository at this point in the history
  2. chore: move changelog entry

    SimenB committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    c38615e View commit details
    Browse the repository at this point in the history
  3. normalize tests

    SimenB committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    7ac2a3c View commit details
    Browse the repository at this point in the history
  4. update snapshot

    SimenB committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    ef15826 View commit details
    Browse the repository at this point in the history