Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace for dependency extractor #7349

Merged

Conversation

rubennorte
Copy link
Contributor

@rubennorte rubennorte commented Nov 9, 2018

Summary

Changed the interface for the new dependency extractors feature to be a namespace/object instead of a function. This is a prerequisite to add getCacheKey to invalidate any caches that have been created using this logic when it changes (#7350).

Test plan

Updated unit tests

@rubennorte rubennorte force-pushed the use-namespace-for-dependency-extractor branch from 03f45d1 to 0da47a8 Compare November 9, 2018 15:42
@rubennorte rubennorte merged commit 213d8e5 into jestjs:master Nov 9, 2018
@rubennorte rubennorte deleted the use-namespace-for-dependency-extractor branch November 9, 2018 16:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants