Make ignorePattern optional in HasteMap #7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
make-ignore-pattern-optional-in-haste-map
branch
from
73adb54
to
03199e5
Compare
rubennorte
force-pushed
the
make-ignore-pattern-optional-in-haste-map
branch
from
03199e5
to
c3bef12
Compare
SimenB
reviewed
Oct 15, 2018
| @@ -54,7 +54,7 @@ type Options = { | |||
| extensions: Array<string>, | |||
| forceNodeFilesystemAPI?: boolean, | |||
| hasteImplModulePath?: string, | |||
| ignorePattern: HasteRegExp, | |||
| ignorePattern?: ?HasteRegExp, | |||
There was a problem hiding this comment.
It was just convenient to avoid handling optional properties in the options passed from jest-runtime. Options has it as an optional nullable property and InternalOptions has it only nullable (not optional). Not sure if this is considered a bad practice though.
SimenB
approved these changes
Oct 16, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the need to pass an ignore pattern to new instances of
HasteMapand updatesjest-runtimeso it doesn't pass one unless it's necessary.Test plan
Updated the current tests and tested in FB infra.