Use FORCE_COLOR=0 for all tests

[hron]

Summary

This change ensures that the tests work regardless of the value of
FORCE_COLOR environment variable. There are environments where this
variable is set to 1 and the tests fail. For example the tests fail when
they are run from Jetbrains IDEs (Rubymine, Webstorm and etc).

istanbul-* packages were updated because 1.* version uses old support-colors package that doesn't allow to disable colors with FORCE_COLOR=0. Instead it interpreters zero value in the same way as 1 or anything else by forcing colors. The latest version of istanbul uses the updated package that disables colors if FORCE_COLOR=0

I suppose this patch is the logical final for #5646 and #5652.

Test plan

If you run tests on master with defined FORCE_COLOR=1 you will receive this:

PS E:\src\jest> $Env:FORCE_COLOR=1; yarn jest
...skip...
Test Suites: 45 failed, 234 passed, 279 total
Tests:       131 failed, 91 skipped, 2599 passed, 2821 total
Snapshots:   15 failed, 10 obsolete, 982 passed, 997 total
Time:        537.5s, estimated 563s

With this patch applied the situation is resolved and all tests pass regardless of the value of FORCE_COLOR.

[SimenB]

This pulls in a lot of babel 7 stuff, I don't think we can do that (see #6562).

Can we run strip-ansi on all coverage output or something to avoid the dependency bump?

[hron]

@SimenB Okay! I've just updated the patch to avoid any dependency bumps. I used strip-ansi as you suggested, but it was added in runJest to avoid repetition. Let me know if it's a bad idea!

[orta]

If you rebase, it /should/ fix your CI

[SimenB]

@hron could you rebase?

[codecov-io]

Codecov Report

Merging #6585 into master will decrease coverage by 3.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6585      +/-   ##
==========================================
- Coverage   67.27%   63.73%   -3.54%     
==========================================
  Files         248      235      -13     
  Lines        9652     8935     -717     
  Branches        3        3              
==========================================
- Hits         6493     5695     -798     
- Misses       3158     3239      +81     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-validate/src/warnings.js	54.54% <0%> (-45.46%)	⬇️
packages/jest-validate/src/errors.js	54.54% <0%> (-45.46%)	⬇️
packages/jest-runtime/src/helpers.js	50% <0%> (-40.48%)	⬇️
packages/jest-runner/src/index.js	47.82% <0%> (-27.18%)	⬇️
packages/jest-editor-support/src/Process.js	66.66% <0%> (-26.67%)	⬇️
packages/jest-each/src/index.js	77.77% <0%> (-22.23%)	⬇️
packages/jest-haste-map/src/worker.js	73.33% <0%> (-20.96%)	⬇️
packages/jest-docblock/src/index.js	80% <0%> (-20%)	⬇️
packages/jest-leak-detector/src/index.js	66.66% <0%> (-16.67%)	⬇️
packages/jest-editor-support/src/Settings.js	71.05% <0%> (-15.62%)	⬇️
... and 176 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9818dc...48574de. Read the comment docs.

[SimenB]

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.