Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with Jest Circus when passing the JEST_CIRCUS env variable as 1 #6285

Merged
merged 4 commits into from
May 26, 2018

Conversation

captbaritone
Copy link
Contributor

@captbaritone captbaritone commented May 26, 2018

Summary

Relates to #4362

You can now run our test with: JEST_CIRCUS=1 ./jest and it will use Jest circus.

This will:

  1. Make it easy to run a test locally with Jest Circus
  2. Enable us to flag individual tests as known to be failing on Jest
    Circus.
  3. Make it easy to run Jest Circus on other code bases.
  4. Once 2 is complete, we can setup a second CI run that uses Jest
    Circus to ensure we don't regress.

Test plan

screen shot 2018-05-26 at 4 22 33 pm

@aaronabramov

This will:

1. Make it easy to run a test locally with Jest Circus
2. Enable us to flag individual tests as known to be failing on Jest
   Circus.
3. Make it easy to run Jest Circus on other code bases.
4. Once 2 is complete, we can setup a second CI run that uses Jest
   Circus to ensure we don't regress.

/* eslint-disable jest/no-focused-tests */

const SkipOnWindows = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkipOnJestCircus :)

@thymikee thymikee merged commit c5994de into jestjs:master May 26, 2018
@rickhanlonii
Copy link
Member

Very cool

@cpojer
Copy link
Member

cpojer commented May 26, 2018

Mind creating an issue to remove this env var once circus is shipped?

@captbaritone
Copy link
Contributor Author

@cpojer Here's an issue of the steps needed to ship Jest Circus: #6295 I'm sure I'm missing stuff, but it can serve as a starting place.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants