Stops using realpath in the resolution

[arcanis]

Summary

The default resolver uses realpath to ensure that multiple identical paths always share the same underlying module. This is a behavior that should belong to the component instantiating the modules rather than the one resolving the paths.

One example of problem it could cause is when using yarn link with peer dependencies. In this case, it's important to preserve the symlinks as they are in order to properly resolve the peer dependencies relative to the location of the symlink rather than the one of the actual package on the filesystem.

Test plan

Existing tests should still pass.

[arcanis]

cc @mjesun @cpojer

[cpojer]

Looks good. This now matches what node's resolution algorithm does by creating two instances, right?

A test that verifies the changed behavior would be good, otherwise we may break this again.

cc @gaearon who frequently brought this up

[gaearon]

Here's two PRs related to realpath that I sent that were fixing issues:

• Fix NODE_PATH resolving for relative paths #3616
• Preserve module identity for symlinks #4761

I don't remember the context around those changes but as long as test cases I added pass I'm good.

[mjesun]

Isn't this going to change all the logic for symlinks? The changed code won't dereference symlinks, so the comment above is not correct anymore.

I'm also not sure if this is something we'd change, it can have unexpected side effects.

[arcanis]

Yeah, I'll retract this change, I have a better one.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.