Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Reword 3-argument jest.spyOn description #5255

Merged
merged 4 commits into from
Jan 9, 2018
Merged

docs: Reword 3-argument jest.spyOn description #5255

merged 4 commits into from
Jan 9, 2018

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Jan 8, 2018

Summary

Slight adjustments to the description of 3-argument jest.spyOn method.

@codecov-io
Copy link

Codecov Report

Merging #5255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5255   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files         203      203           
  Lines        6843     6843           
  Branches        3        4    +1     
=======================================
  Hits         4184     4184           
  Misses       2658     2658           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2daf8fe...71ce740. Read the comment docs.

SimenB
SimenB approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run yarn lint:md for extra goodness 🙂

SimenB
SimenB reviewed Jan 9, 2018
View reviewed changes
docs/JestObjectAPI.md Outdated

Example:

```js
const video = {
get play() { // it's a getter!
get play() {
// it's a getter!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move comment above? same with "setter"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Fooled by partial git diff from the email

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018 •
edited
Loading

Something's up with circle: tar: root/jest/node_modules: Cannot mkdir: Permission denied. Maybe they're patching meltdown or something

@thymikee
Copy link
Collaborator Author

thymikee commented Jan 9, 2018

Yea, totally unrelated to this change. Thanks for updating the changelog with PR num :)

@cpojer cpojer merged commit 6931b0f into master Jan 9, 2018
@SimenB SimenB deleted the thymikee-patch-1 branch January 9, 2018 08:58
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thymikee @codecov-io @SimenB @cpojer @facebook-github-bot