Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add jest-puppeteer example #5093

Merged
merged 1 commit into from
Dec 17, 2017
Merged

docs: add jest-puppeteer example #5093

merged 1 commit into from
Dec 17, 2017

Conversation

xfumihiro
Copy link
Contributor

Added a guide for usage with puppeteer

@codecov-io
Copy link

codecov-io commented Dec 16, 2017 •
edited
Loading

Codecov Report

Merging #5093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5093   +/-   ##
=======================================
  Coverage   60.58%   60.58%           
=======================================
  Files         201      201           
  Lines        6686     6686           
  Branches        4        4           
=======================================
  Hits         4051     4051           
  Misses       2635     2635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df92340...e9d761c. Read the comment docs.

@xfumihiro xfumihiro mentioned this pull request Dec 16, 2017
Closed
SimenB
SimenB reviewed Dec 16, 2017
View reviewed changes
docs/Puppeteer.md Outdated
```js
// setup.js
module.exports = function() {
return new Promise((resolve, reject) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use async-await in the examples

docs/Puppeteer.md Outdated
---

With the
[Global Setup/Teardown](https://facebook.github.io/jest/docs/en/configuration.html#globalsetup-string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to have relative links here?

@cpojer
Copy link
Member

cpojer commented Dec 17, 2017

Cool! I hope this integration makes people happy :)

@cpojer cpojer merged commit 486444b into jestjs:master Dec 17, 2017
@renovate-tests renovate-tests mentioned this pull request Feb 6, 2018
Closed
@renovate renovate bot mentioned this pull request Feb 14, 2018
Open
@vladholubiev vladholubiev mentioned this pull request Feb 15, 2018
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xfumihiro @codecov-io @cpojer @SimenB @facebook-github-bot