Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support file #5091

Merged
merged 3 commits into from
Dec 17, 2017
Merged

chore: add support file #5091

merged 3 commits into from
Dec 17, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 16, 2017

Summary
See https://help.github.com/articles/adding-support-resources-to-your-project/

Maybe people will read it 🙂 The text could maybe be expanded?

Test plan
Docs only

@codecov-io
Copy link

codecov-io commented Dec 16, 2017

Codecov Report

Merging #5091 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5091   +/-   ##
=======================================
  Coverage   60.58%   60.58%           
=======================================
  Files         201      201           
  Lines        6686     6686           
  Branches        4        4           
=======================================
  Hits         4051     4051           
  Misses       2635     2635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df92340...51e56d1. Read the comment docs.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to jestjs tag on SO?

@cpojer cpojer merged commit abba9e5 into jestjs:master Dec 17, 2017
@cpojer
Copy link
Member

cpojer commented Dec 17, 2017

Oh, I didn't now this was a thing. Thanks for getting this started, I think we should work on a larger message there that makes people feel more supported. I also wanted to update my canned reply to sound a bit more supportive and nice, maybe we can work on something together.

@SimenB SimenB deleted the support-file branch December 17, 2017 09:45
@SimenB
Copy link
Member Author

SimenB commented Dec 17, 2017

Yeah, should probably expand it a bit.

It does show up, but it's not super visual. It's something to point to when closing at least 🙂

image

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants