Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use declare module.exports syntax for flow libdefs #5086

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

samwgoldman
Copy link
Contributor

@samwgoldman samwgoldman commented Dec 15, 2017

Summary

We added this to Flow in v0.25 (about 2 years ago), but never actually
deprecated the legacy declare var exports syntax. Hoping to do that
soon, so clearing up uses that I can find.

Test plan

flow

@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #5086 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5086   +/-   ##
=======================================
  Coverage   60.65%   60.65%           
=======================================
  Files         199      199           
  Lines        6643     6643           
  Branches        4        4           
=======================================
  Hits         4029     4029           
  Misses       2614     2614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb7ee1...e812632. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Dec 15, 2017

I'm confused...

never actually deprecated the legacy declare var exports syntax.

This diff adds declare var exports.

@samwgoldman
Copy link
Contributor Author

@SimenB Oops! Updated.

We added this to Flow in v0.25 (about 2 years ago), but never actually
deprecated the legacy `declare var exports` syntax. Hoping to do that
soon, so clearing up uses that I can find.

Test Plan: flow
@cpojer cpojer merged commit 20d9fbf into jestjs:master Dec 15, 2017
@cpojer
Copy link
Member

cpojer commented Dec 15, 2017

Thanks for updating this @samwgoldman! :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants