Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add new "setupTestFramework" option (#4976)" #5025

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Revert "Add new "setupTestFramework" option (#4976)" #5025

merged 1 commit into from
Dec 6, 2017

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Dec 6, 2017

This reverts commit dbfd787. I had to manually revert because the Github UI seems broken.

@mjesun
Copy link
Contributor Author

mjesun commented Dec 6, 2017

This is related to the reversion of #4970. Since it got also reverted, this out-of-the-sandbox option is not needed anymore (at least for now), so it's better to get back to the original setup.

@cpojer cpojer merged commit 6ade256 into jestjs:master Dec 6, 2017
@codecov-io
Copy link

Codecov Report

Merging #5025 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   60.42%   60.37%   -0.05%     
==========================================
  Files         198      198              
  Lines        6640     6637       -3     
  Branches        3        4       +1     
==========================================
- Hits         4012     4007       -5     
- Misses       2628     2630       +2
Impacted Files Coverage Δ
packages/jest-config/src/valid_config.js 100% <ø> (ø) ⬆️
packages/jest-config/src/index.js 23.8% <ø> (ø) ⬆️
packages/jest-jasmine2/src/index.js 5.97% <ø> (+0.25%) ⬆️
packages/jest-config/src/normalize.js 92.94% <ø> (ø) ⬆️
packages/jest-validate/src/warnings.js 44.44% <0%> (-55.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce82e6...98a897d. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Dec 6, 2017

Alright, let's do this for now.

@mjesun mjesun deleted the revert-setup-test-framework branch February 7, 2018 10:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants