Call jest-diff and pretty-format more precisely in toHaveProperty matcher #4445
Conversation
packages/expect/src/matchers.js
Outdated
| ? diff(value, result.value, { | ||
| expand: this.expand, | ||
| }) | ||
| : ''; |
There was a problem hiding this comment.
Can we put this in one line for readability?
? diff(value, result.value, {expand: this.expand})
: '';There was a problem hiding this comment.
Yes, good call.
| (hasEndProp | ||
| ? `Received:\n` + | ||
| ` ${printReceived(result.value)}` + | ||
| (diffString ? `\n\nDifference:\n\n${diffString}` : '') |
There was a problem hiding this comment.
\n\nDifference
is this double newline intended? Old code has only one.
There was a problem hiding this comment.
Ok, I see from snapshot that it actually looks better now 👍
There was a problem hiding this comment.
EDIT: Good eyes! Yes, the double newline is following pattern of toEqual matcher.
pedrottimark
changed the title
|
EDIT: It’s not yet clear to me if eager evaluation of diff caused perf problem for examples in #3847 |
…cher (jestjs#4445) * Call diff more precisely in toHaveProperty matcher * Write diff call on one line for readability
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
EDITED:
diffif and only ifvaluePassed && hasEndProppretty-formatfor received property value, not for its parent objectlastTraversedObjectif and only iftraversedPathnon-empty and incompleteTest plan
Updated 3 snapshots