Support mocking native async methods #3209
Conversation
thymikee
changed the title
Generated by 🚫 dangerJS |
| const native = require('../native'); | ||
|
|
||
| test('mock works with native async', () => { | ||
| expect(native.asyncMethod).toBeDefined(); |
There was a problem hiding this comment.
can we make it to return a promise though? :)
There was a problem hiding this comment.
So actually, the problem here is not with defining implementation of mock (which works well in both scenarios) but rather with method availability. When a method is an AsyncFunction type, its name isn't copied to the mock, but it does for sync methods, so I figured out we should follow this pattern. Does it make sense?
| @@ -127,7 +127,7 @@ function isReadonlyProp(object: any, prop: string): boolean { | |||
| prop === 'callee' || | |||
| prop === 'name' || | |||
| prop === 'length') && | |||
| isA('Function', object)) || | |||
| (isA('Function', object) || isA('AsyncFunction', object))) || | |||
|
Can we move this from examples into an integration test instead? I don't think this needs to be an example :) You can even make this a regular test inside of jest-mock and simply skip it if the node version is <7.5 or so. How about that? |
|
Sure, I'll send a followup some time later. |
* Support mocking native AsyncFunction * Add native-async-mock example test * Use strict * Return a promise from mock * Only test async * Revert returning promise
* Support mocking native AsyncFunction * Add native-async-mock example test * Use strict * Return a promise from mock * Only test async * Revert returning promise
|
This fix does not seem to work for me. Please see my test here where I have tried to mock an async method in a module. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3135
Test plan
New directory in
asyncexample with no babel async transform. Passes here, fails on current master.