[jest-resolve] Use is-builtin-module instead of resolve.isCore.
#2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
Feb 24, 2017
| expect(isCore).toEqual(false); | ||
| }); | ||
|
|
||
| it('returns true if `hasCoreModules` is false and `moduleName` is a core module.', () => { |
There was a problem hiding this comment.
Thank you.
There was a problem hiding this comment.
Wait, this doesn't make sense.
- If
hasCoreModulesis true, it should return true if you pass in a core module. If it is false, it should return false when passing in a core module. - If
hasCoreModuleis true, it should return false if you pass in a non-core module. If it is false, it should always return false.
There was a problem hiding this comment.
Isn't that what it is doing? Should I have a test for hasCoreModule: false and isCore('non-core-module')?
|
You are right. Do you mind removing "browser: false"? It doesn't really do anything and confuses me :) |
Generated by 🚫 dangerJS |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
…estjs#2997) * Use `is-builtin-module` instead of `resolve.isCore`. * Fix typo. * Remove `browser: false`.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…estjs#2997) * Use `is-builtin-module` instead of `resolve.isCore`. * Fix typo. * Remove `browser: false`.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses
is-builtin-moduleto determine if a module is a core module instead ofresolve.isCore.resolveis going away with #2925 andis-builtin-moduleis already in the dependency tree (not specifically ofjest-resolve).Test plan
Write tests for
Resolver.isCore.