Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved failure message readability of failing ObjectContaining tests #15038

Merged
merged 3 commits into from
May 12, 2024

Conversation

colinacassidy
Copy link
Contributor

Summary

Improves failure message readability of failing ObjectContaining tests by removing highlighting from irrelevant keys. Closes #14897

ex, changes error message from:

- Expected  - 2
+ Received  + 3

- ObjectContaining {
+ Object {
+   "a": 1,
    "b": 2,
-   "c": 2,
+   "c": 3,
  }

to:

- Expected  - 2
+ Received  + 2

- ObjectContaining {
+ Object {
    "a": 1,
    "b": 2,
-   "c": 2,
+   "c": 3,
  }

Test plan

Modify unit test for ObjectContaining to reflect this behavior shown above.

Copy link

linux-foundation-easycla bot commented Apr 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 528ae0a
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6641330a8330030008975efe
😎 Deploy Preview https://deploy-preview-15038--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 169ba83 into jestjs:main May 12, 2024
8 of 9 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong diff for objectContaining
2 participants