Update NodeEnvironment to provide dispose global symbols #14888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
notaphplover
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to solve #14874.
As said in the issue, since typescript 5.2, Explicit Resource Management is being supported in Typescript. Latest stable NodeJS versions include
Symbol.disposeandSymbol.asyncDispose, essential to pollyfill this feature. Exposing them in the jest node env would allow to properly test modules using this feature.The vm node API generates by default a global object with standard properties. I think it makes sense the node env provides dispose Symbols if the host runtime is providing them in order to use NodeJS supported features relying in those symbols.
Test plan
Symbolis set as the vm globalSymbol.