Docs: Update .toHaveBeenCalled() documentation #14847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .toHaveBeenCalled name and description. Its description now correctly reflects that it is not called with any arguments.
Updated .toHaveBeenCalled name and description. Its description now correctly reflects that it is not called with any arguments.
Updated .toHaveBeenCalled name and description. Its description now correctly reflects that it is not called with any arguments.
Updated .toHaveBeenCalled name and description. Its description now correctly reflects that it is not called with any arguments.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated changelog entry to be more reflective of change.
Updated with more specific documentation change descriptions in changelog.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change concerns issue #14842, where .toHaveBeenCalled() and .toHaveBeenCalledWith() have duplicate descriptions despite serving two different functionalities. I made this change because .toHaveBeenCalled() refers to an example where there are no function parameters, and therefore should be updated accordingly because it was not called with specific arguments. Therefore, I took out the argument explanations and simply revised the description to correctly reflect
.toHaveBeenCalled's functionality.I additionally updated the descriptions for all versioned docs which concern this documentation issue.
Fixes #14842
Test plan
By updating the documentation, I then ran it on the documentation website node server to make sure changes were updated accordingly. Jest documentation versions 29.7, 29.6, 29.5, and 29.4 were changed.
Documentation on the server now showing corrected values.