Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add coverageReporters to ValidConfig.ts #14830

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: add coverageReporters to ValidConfig.ts #14830

merged 1 commit into from
Jan 5, 2024

Conversation

JimminiKin
Copy link
Contributor

@JimminiKin JimminiKin commented Jan 4, 2024 •
edited
Loading

Summary

Should fix #14701

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 4, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JimminiKin / name: Jimmy Thomas (68fae36)

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2024 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68fae36
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/659803fdb1970a0008698b50
😎 Deploy Preview https://deploy-preview-14830--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JimminiKin JimminiKin marked this pull request as ready for review January 4, 2024 17:11
@JimminiKin JimminiKin changed the title Add coverageReporters to ValidConfig.ts fix: add coverageReporters to ValidConfig.ts Jan 4, 2024
@JimminiKin JimminiKin marked this pull request as draft January 4, 2024 17:24
@SimenB
Copy link
Member

SimenB commented Jan 5, 2024

Thanks for sending a PR!

yarn jest logDebugMessages ScriptTransformer showConfig -u should fix the tests

@JimminiKin JimminiKin marked this pull request as ready for review January 5, 2024 13:42
@JimminiKin
Copy link
Contributor Author

Thx for the help @SimenB, looks good now for tests 🙏

SimenB
SimenB approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 8c3db5c into jestjs:main Jan 5, 2024
73 checks passed
@JimminiKin JimminiKin deleted the patch-1 branch January 5, 2024 14:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unknown option "coverageReporters" validation warning when used for projects
2 participants
@JimminiKin @SimenB