docs(SnapshotTesting.md): Additionally mention snapshot serializer in "replacing random string part" section #14175
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
|
maro1993
force-pushed
the
docfix-random-strings-snapshotserializer
branch
from
0da0507
to
d09904b
Compare
Mention snapshot serializer as a valid way to replace random strings.
|
@SimenB CLA is signed |
|
/easycla |
|
Seems the email used in the commit is not the same as your GitHub user or something? |
|
@SimenB yup but i resolved this as you can see in the checks. I "hard" resetted my branch and comitted my changes as a new commit so the bot warnings from before can be ignored.
|
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The tip Box in SnapshotTesting.md gives the impression that there are only two ways to replace random string parts in a snapshot. It forgets to mention that you can handle string replacements elegantly with the snapshot serializer. I updated the box and mentioned snapshot serializer as a valid way to replace random string parts globally and testwise.
Test plan
The change is so trivial i don't think this is needed here.