Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run prettier on everything #12653

Merged
merged 9 commits into from
Apr 12, 2022
Merged

chore: run prettier on everything #12653

merged 9 commits into from
Apr 12, 2022

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Apr 8, 2022

Summary

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @fisker!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

{{else}}
evening
{{/if}}
{{name}}!</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug in Prettier, it removed the final new line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the failing test as well btw, changed the coverage report. Can add an ignore comment so we can land this PR?

@SimenB
Copy link
Member

SimenB commented Apr 8, 2022

Thanks!

Huh, eslint is supposed to run on all ts and js (with prettier plugin). seemingly not working correctly...

@fisker
Copy link
Contributor Author

fisker commented Apr 8, 2022

eslint is supposed to run on all ts and js

Didn't notice that, excluded **/*.{js,jsx,cjs,mjs,ts,tsx,md} no reason to run Prettier twice.

.eslintignore Outdated Show resolved Hide resolved
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

package.json Outdated Show resolved Hide resolved
@@ -19,5 +19,5 @@ module.exports = {
},
],
'@babel/preset-typescript',
]
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest diff in the end 😀

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 59d3e51 into jestjs:main Apr 12, 2022
@fisker fisker deleted the prettier branch April 12, 2022 09:38
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants