Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-runner): Add info regarding timers to forceExited message #12083

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

silverwind
Copy link
Contributor

@silverwind silverwind commented Nov 24, 2021

Summary

When a test finishes while a Node.js timer is still active, the worker process will have to be force-killed by jest because the active timer will keep the event loop alive.

It is often not immediately clear that such timers are the issue for this message and the suggested method of --detectOpenHandles will never detect them. Add a helpful message to point the user to this potential issue.

Ref: https://nodejs.org/api/timers.html#timeoutunref

Test plan

None, It's just a small addition to a warning message.

@silverwind silverwind changed the title Add info regarding timers to forcedExit message. chore(jest-runner): Add info regarding timers to forcedExit message Nov 24, 2021
@silverwind silverwind changed the title chore(jest-runner): Add info regarding timers to forcedExit message chore(jest-runner): Add info regarding timers to forceExited message Nov 24, 2021
When a test finishes while a Node.js timer is still active, the worker
process will have to be force-killed by jest because the active timer
will keep the event loop alive.

It is often not immediately clear that such timers are the issue for this
message and the suggested method of `--detectOpenHandles` will never
detect them. Add a helpful message to point the user to this potential
issue.

Ref: https://nodejs.org/api/timers.html#timeoutunref
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants