Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced substr with substring #12066

Merged
merged 6 commits into from
Nov 18, 2021
Merged

replaced substr with substring #12066

merged 6 commits into from
Nov 18, 2021

Conversation

k-rajat19
Copy link
Contributor

JS string substr gives deprecated warning it should be avoided to use.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr

code

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #12066 (62e8179) into main (42b020f) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12066   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files         324      324           
  Lines       16669    16669           
  Branches     4814     4814           
=======================================
  Hits        11483    11483           
  Misses       5153     5153           
  Partials       33       33           
Impacted Files Coverage Δ
packages/jest-config/src/utils.ts 69.56% <ø> (ø)
packages/jest-snapshot/src/index.ts 78.61% <0.00%> (ø)
packages/jest-haste-map/src/lib/fast_path.ts 100.00% <100.00%> (ø)
packages/jest-haste-map/src/worker.ts 95.65% <100.00%> (ø)
packages/jest-transform/src/ScriptTransformer.ts 79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b020f...62e8179. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I left one inline comment, but in addition to that, could you update the changelog?
🙂

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title deprecated : replaced string substr with substring replaced substr with substring Nov 18, 2021
@SimenB SimenB merged commit 7bb400c into jestjs:main Nov 18, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants