Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tell Babel about Jest's ESM support #10750

Closed
wants to merge 1 commit into from
Closed

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 31, 2020

Summary

This is mostly to have @babel/preset-env leave some constructs alone.

Test plan

Green CI - it's just passing stuff through to Babel.

@SimenB SimenB added this to the Jest 27 milestone Oct 31, 2020
@@ -96,6 +104,7 @@ export default class ScriptTransformer {
instrument: boolean,
supportsDynamicImport: boolean,
supportsStaticESM: boolean,
supportsTopLevelAwait: boolean,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing this around is a mess, so I think we should wait until Jest 27 and move to passing objects (which is a breaking refactor)

@SimenB
Copy link
Member Author

SimenB commented Oct 31, 2020

The most important bits are in #10752, I'll open a new PR for passing these through @jest/transform into transformers

@SimenB SimenB closed this Oct 31, 2020
@SimenB SimenB deleted the tla branch October 31, 2020 15:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants