Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PCancelable to typescript #10215

Merged
merged 6 commits into from
Jul 4, 2020
Merged

Convert PCancelable to typescript #10215

merged 6 commits into from
Jul 4, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 28, 2020

Summary

Found while looking to remove some usages of Function type for #10177.

By converting PCancelable to TypeScript, the Function types can be dropped in favor of the types being inferred.
I also axed the canceled getter, and fn static property as they're not used, and the latter is painful to accurately type.

Finally, also typed the return of queueRunner & refined some any types.

Test plan

Ran the build, TypeScript was happy.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

packages/jest-jasmine2/src/queueRunner.ts Outdated Show resolved Hide resolved
@SimenB SimenB merged commit e8b7f57 into jestjs:master Jul 4, 2020
@G-Rath G-Rath deleted the convert-PCancelable-to-typescript branch July 4, 2020 23:06
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants