Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when nodegit is referenced from several places #3550

Closed
stukalin opened this issue May 11, 2017 · 3 comments
Closed

Error when nodegit is referenced from several places #3550

stukalin opened this issue May 11, 2017 · 3 comments

Comments

@stukalin
Copy link

stukalin commented May 11, 2017 •
edited
Loading

If nodegit is referenced in more than 1 test file (even not directly) then Jest throws random errors related to promisify-node like:
TypeError: Cannot convert undefined or null to object at processExports (node_modules/promisify-node/index.js:44:16) at Object.<anonymous> (index.js:1:106) at Object.<anonymous> (__tests__/index.test.js:1:100)
Steps could be following:

  1. install jest and nodegit; create a module which requires nodegit and 2 tests which require the module
  2. run jest

I've created a repo illustrating that.
https://github.com/stukalin/jest-nodegit-issue
Simply run yarn install && yarn test. Note, that sometimes tests pass, but simply repeat 2-3 times.

With --no-cache it works

My conf:
OS: Ubuntu 16.04
Jest: v20.0.1
nodegit: latest (0.18.3)
yarn: 0.23.4
npm: 3.10.10
node: v6.10.2
@thymikee
Copy link
Collaborator

Looks like we hit similar problem as here: #2029

@thymikee thymikee mentioned this issue May 11, 2017
Closed
@thymikee
Copy link
Collaborator

Closing due to: #3552

@karlhorky karlhorky mentioned this issue Jun 22, 2017
Closed
jmurzy added a commit to jmurzy/nodegit that referenced this issue Aug 14, 2017
@jmurzy
fix issue with re-require()'ing native modules
50ad8d5 
A summary of why this change was required is discussed in the following issues:

jestjs/jest#3552
jestjs/jest#3550
nodejs/node#5016
jmurzy added a commit to jmurzy/nodegit that referenced this issue Aug 14, 2017
@jmurzy
fix issue with re-require()'ing native modules
59f966c 
Discussion on why this change was required can be found in the following issues:

jestjs/jest#3552
jestjs/jest#3550
nodejs/node#5016
jmurzy added a commit to jmurzy/nodegit that referenced this issue Aug 14, 2017
@jmurzy
fix issue with re-require()'ing native modules
a71d97c 
Discussion on why this change was required can be found in the following issues:

jestjs/jest#3552
jestjs/jest#3550
nodejs/node#5016
@jmurzy jmurzy mentioned this issue Aug 14, 2017
Merged
sorenlouv pushed a commit to sorenlouv/nodegit that referenced this issue Oct 1, 2017
@jmurzy @sorenlouv
fix issue with re-require()'ing native modules
1ddbba4 
Discussion on why this change was required can be found in the following issues:

jestjs/jest#3552
jestjs/jest#3550
nodejs/node#5016
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thymikee @stukalin