Removed instrument check before saving sourceMap. Updated the changel…

…og with this pull
jestjs · Jan 16, 2018 · 24d8228 · 24d8228
1 parent 46e5ec5
commit 24d8228
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### Fixes
 
+* `[jest-runtime]` Removed check for `mapCoverage` boolean before attempting to read inlineSourceMaps. [#5177](https://github.com/facebook/jest/pull/5177)
 * `[jest-cli]` Fix `EISDIR` when a directory is passed as an argument to `jest`.
   ([#5317](https://github.com/facebook/jest/pull/5317))
 

diff --git a/...e_remapping_inline_sourcemap.test.js.snap → ...e_remapping_inline_sourcemap.test.js.snap b/...e_remapping_inline_sourcemap.test.js.snap → ...e_remapping_inline_sourcemap.test.js.snap
diff --git a/...verage_remapping_inline_sourcemap.test.js → ...verage_remapping_inline_sourcemap.test.js b/...verage_remapping_inline_sourcemap.test.js → ...verage_remapping_inline_sourcemap.test.js
diff --git a/...nline-sourcemap/__tests__/covered-test.js → ...nline-sourcemap/__tests__/covered-test.js b/...nline-sourcemap/__tests__/covered-test.js → ...nline-sourcemap/__tests__/covered-test.js
diff --git a/...age-remapping-inline-sourcemap/covered.js → ...age-remapping-inline-sourcemap/covered.js b/...age-remapping-inline-sourcemap/covered.js → ...age-remapping-inline-sourcemap/covered.js
diff --git a/...e-remapping-inline-sourcemap/package.json → ...e-remapping-inline-sourcemap/package.json b/...e-remapping-inline-sourcemap/package.json → ...e-remapping-inline-sourcemap/package.json
diff --git a/packages/jest-runtime/src/script_transformer.js b/packages/jest-runtime/src/script_transformer.js
@@ -243,6 +243,8 @@ export default class ScriptTransformer {
     }
 
     if (!transformed.map) {
+      //Could be a potential freeze here.
+      //See: https://github.com/facebook/jest/pull/5177#discussion_r158883570
       const inlineSourceMap = convertSourceMap.fromSource(transformed.code);
       if (inlineSourceMap) {
         transformed.map = inlineSourceMap.toJSON();
@@ -259,7 +261,7 @@ export default class ScriptTransformer {
       code = transformed.code;
     }
 
-    if (instrument && transformed.map) {
+    if (transformed.map) {
       const sourceMapContent =
         typeof transformed.map === 'string'
           ? transformed.map