-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Install headers #1896
build: Install headers #1896
Conversation
Can you introduce what iotjs-dev is? |
It's a common pratice to install developers files in a separate package (to save storage), |
|
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b Bug: jerryscript-project#1945 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b Bug: jerryscript-project#1945 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896). Also remove headers, lib when installing executable. This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896). Also remove headers, lib when installing executable. This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
This change can be ignored if this other change is merged: |
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package The extra archive rule is needed to prevent this error: install TARGETS given no ARCHIVE DESTINATION for static library target Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Installing the static lib will also install headers (Fixes: #1896). This is useful for debian's iotjs-dev package. The extra archive rule is needed to prevent this error: install TARGETS given no ARCHIVE DESTINATION for static library target Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: #1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: #1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: #1896 Last-Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Reintroduce this feature after 99ec371
It was useful for debian packaging (iotjs-dev)
Relate-to: #1145
Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com