Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#93 #95

Merged
merged 3 commits into from
Mar 31, 2017
Merged

Issue#93 #95

merged 3 commits into from
Mar 31, 2017

Conversation

Pontusfroding
Copy link
Contributor

fix for #93

Now all template namespaces have been added and I can add people if I don't use pagesets. There seems to be some issue there.

Class 'pager' not found in php/traits/showPage.inc.php on line 72

@jeroenrnl
Copy link
Owner

I think I have created a fix for the "Class pager" issue recently... Have you checked with the "hotfix" branch?

@Pontusfroding
Copy link
Contributor Author

Can't see anything about it being fixed in there unfortunately.

Is anybody using the pagesets? :)

@jeroenrnl
Copy link
Owner

Great, thanks!
Two small requests: could you use use template\template instead of adding the namespace to the call? And also, in templates I use instead of
I'd be happy to change it, BTW, but I'm still figuring out how to pull a commit into a different branch then "master" :-)

@jeroenrnl
Copy link
Owner

I will also look into the showPage issue...

@jeroenrnl
Copy link
Owner

I have reproduced it on my system

@jeroenrnl
Copy link
Owner

Ok, the pager issue is fixed (see 22fb768) and I have found a way to pull your changes into my issue#93 branch. Do you want to make the fixes above or should I do it?

@Pontusfroding
Copy link
Contributor Author

You are always free to do what fits you best with my patches.

Anyway I have now updated the branch.

@jeroenrnl jeroenrnl merged commit cca9f2c into jeroenrnl:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants