Configure the content-header of template

[warquia]

| Question | Answer
| ----------------------- | [-----------------------]
| Issue or Enhancement | Enhancement
| License | MIT

What's in this PR?

Allowing you to generate or not a content-header, thus allowing at 1024x768 resolutions gains more screen space,

Checklist

• I tested these changes.
  

[resslinger]

Please add a fallback, if the config var is not set.

[warquia]

add fallback

[dfsmania]

@warquia what classes did you have added to the new config option you have created to get from picture 1 to picture 2. If the goal is to not shown the content-header when the section is not used, we can do like next:

{{-- Content Header --}}
@hasSection('content-header')
    <div class="content-header">
        <div class="{{ config('adminlte.classes_content_header') ?: $def_container_class }}">
            @yield('content_header')
        </div>
    </div>
@endif

Also, note when you do:

<div class="{{ config('adminlte.classes_content_header_main' , 'content-header') }}">

the default value will only be used when the configuration option do not exists. So, when defining the option to null it will inject a null on the class and may result on undesired behavior. You can read laravel docs for details. For this case, I believe it will be better to use:

<div class="{{ config('adminlte.classes_content_header_main') ?: 'content-header' }}">

So, when config('adminlte.classes_content_header_main') evaluates to a falsy value the 'content-header' class will be used.

Also, next time avoid using the master branch of your fork when contributing. Give a fast read to contribution guidelines.

[warquia]

Good morning everyone, really has-section is the best approach, I will correct the pull-request with your analysis.
By the way, I'm new to git so I'm going to send this pull in master yet but next time I'll follow the guidance using a branch

Thank you all

[dfsmania]

Please, do not delete config/adminlte.php file. Just use git checkout config/adminlte.php to restore it to the original one, then commit that one. That way you will rollback the first modifications you have done to that file.

[dfsmania]

@resslinger @warquia This PR is ok for me now...