Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace use of several deprecated methods/classes by their successors #6933

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Aug 28, 2024

Description of Change

While checking the buildlog of the 'update maven requirement to 3.6.3' efforts I spotted several deprecation warnings.
The deprecations within the MavenProject unfortunately do not appear to have a replacement (yet), but as a side-activity I've worked through the other deprecations in order to clean them out of the codebase.

Have test cases been added to cover the new functionality?

not applicable

…en-compiler-plugin configuration

forceJavacCompilerUse was introduced in the past as part of configuring Google ErrorProne.
Google ErrorProne was (temporarily) removed in 2020, but even when introducing it again the
current configuration instructions for using ErrorProne with maven no longer require
this flag to be set as per https://errorprone.info/docs/installation

So rather than using the new flag forceLegacyJavacApi it's better to remove it
@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Aug 28, 2024
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong added this to the 11.0.0 milestone Aug 28, 2024
@jeremylong
Copy link
Owner

Thanks! We'll include this with the 11.0.

@aikebah aikebah merged commit 500ab76 into main Sep 7, 2024
6 checks passed
@aikebah aikebah deleted the scratch/resolveDeprecations branch September 8, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants