build: Switch from JMockit to Mockito & build target to Java 11 #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
ant
aikebah
changed the title
|
@jeremylong you may want to release a 10.x bugfix with the latest changes since 10.0.3 before integrating as this PR also switches minimum java version used at runtime to Java 11. |
|
There will be other breaking changes in 11.0 - so yes, I was planning on another release before merging the breaking changes. |
Created a new 10.0.4 milestone and re-targeted the already merged PRs to that milestone, so that the 11.0.0 milestone now only has the unmerged, breaking, changes allocated |
…sting.jmockit.JMockitToMockito
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6809
Description of Change
Change mocking in the testcases from JMockit ot Mockito and update the compiler-target to Java 11.
Because of the bump in required Java version also updated the version to the next major as from this change onward Java 11 will be required to run DependencyCheck (some of the mocking required Mockito 5 which also requires Java 11)
One testcase, that was already dynamically disabled on Java 8 has been removed now, as I could not find a way to return it to operational state.
Have test cases been added to cover the new functionality?
No new functionality, only a replacement of a mocking framework in the test cases and a bump in Java version