Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DartAnalyzer #4869

Merged
merged 3 commits into from
Sep 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/src/test/resources/sample.properties
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ analyzer.pe.enabled=true
analyzer.hint.enabled=true
analyzer.nvdcve.enabled=true
analyzer.vulnerabilitysuppression.enabled=true
analyzer.dart.enabled=true
updater.nvdcve.enabled=true
updater.versioncheck.enabled=true
analyzer.versionfilter.enabled=true
1 change: 1 addition & 0 deletions cli/src/test/resources/sample2.properties
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ analyzer.pe.enabled=false
analyzer.hint.enabled=false
analyzer.nvdcve.enabled=false
analyzer.vulnerabilitysuppression.enabled=false
analyzer.dart.enabled=true
updater.nvdcve.enabled=false
updater.versioncheck.enabled=false
analyzer.versionfilter.enabled=false
5 changes: 5 additions & 0 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ Copyright (c) 2012 Jeremy Long. All Rights Reserved.
<artifactId>jackson-module-afterburner</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.h3xstream.retirejs</groupId>
<artifactId>retirejs-core</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,256 @@
/*
* This file is part of dependency-check-core.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* Copyright (c) 2022 Marc Rödder. All Rights Reserved.
*/
package org.owasp.dependencycheck.analyzer;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.github.packageurl.MalformedPackageURLException;
import com.github.packageurl.PackageURL;
import com.github.packageurl.PackageURLBuilder;
import org.owasp.dependencycheck.Engine;
import org.owasp.dependencycheck.analyzer.exception.AnalysisException;
import org.owasp.dependencycheck.dependency.Confidence;
import org.owasp.dependencycheck.dependency.Dependency;
import org.owasp.dependencycheck.dependency.EvidenceType;
import org.owasp.dependencycheck.dependency.naming.CpeIdentifier;
import org.owasp.dependencycheck.dependency.naming.PurlIdentifier;
import org.owasp.dependencycheck.utils.Checksum;
import org.owasp.dependencycheck.utils.FileFilterBuilder;
import org.owasp.dependencycheck.utils.Settings;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import us.springett.parsers.cpe.Cpe;
import us.springett.parsers.cpe.CpeBuilder;
import us.springett.parsers.cpe.exceptions.CpeValidationException;
import us.springett.parsers.cpe.values.Part;

import javax.annotation.concurrent.ThreadSafe;
import java.io.File;
import java.io.FileFilter;
import java.io.IOException;
import java.util.Iterator;
import java.util.Map;

/**
* This analyzer is used to analyze Dart packages by collecting
* information from pubspec lock and yaml files. See https://dart.dev/tools/pub/pubspec
*
* @author Marc Rödder (http://github.com/sticksen)
*/
@Experimental
@ThreadSafe
public class DartAnalyzer extends AbstractFileTypeAnalyzer {

// /**
// * A descriptor for the type of dependencies processed or added by this
// * analyzer.
// */
// // currently not supported by Sonatype OSS
// public static final String DEPENDENCY_ECOSYSTEM = Ecosystem.DART;

private static final Logger LOGGER = LoggerFactory.getLogger(DartAnalyzer.class);

private static final String LOCK_FILE = "pubspec.lock";
private static final String YAML_FILE = "pubspec.yaml";

@Override
protected FileFilter getFileFilter() {
return FileFilterBuilder.newInstance().addFilenames(LOCK_FILE, YAML_FILE).build();
}

@Override
protected void prepareFileTypeAnalyzer(Engine engine) {
// NO-OP
}

@Override
public String getName() {
return "Dart Package Analyzer";
}

/**
* @return the phase that the analyzer is intended to run in.
*/
@Override
public AnalysisPhase getAnalysisPhase() {
return AnalysisPhase.INFORMATION_COLLECTION;
}

/**
* Returns the key used in the properties file to reference the analyzer's
* enabled property.
*
* @return the analyzer's enabled property setting key
*/
@Override
protected String getAnalyzerEnabledSettingKey() {
return Settings.KEYS.ANALYZER_DART_ENABLED;
}

@Override
protected void analyzeDependency(Dependency dependency, Engine engine)
throws AnalysisException {
String fileName = dependency.getFileName();
LOGGER.debug("Checking file {}", fileName);

switch (fileName) {
case LOCK_FILE:
analyzeLockFileDependencies(dependency, engine);
break;
case YAML_FILE:
analyzeYamlFileDependencies(dependency, engine);
break;
}
}

private void analyzeYamlFileDependencies(Dependency yamlFileDependency, Engine engine) throws AnalysisException {
engine.removeDependency(yamlFileDependency);

JsonNode rootNode;
File yamlFile = yamlFileDependency.getActualFile();
ObjectMapper objectMapper = new ObjectMapper(new YAMLFactory());
try {
rootNode = objectMapper.readTree(yamlFile);
} catch (IOException e) {
throw new AnalysisException("Problem occurred while reading dependency file.", e);
}

Iterator<Map.Entry<String, JsonNode>> dependencies = rootNode.get("dependencies").fields();
addYamlDependenciesToEngine(dependencies, yamlFile, engine);

Iterator<Map.Entry<String, JsonNode>> devDependencies = rootNode.get("dev_dependencies").fields();
addYamlDependenciesToEngine(devDependencies, yamlFile, engine);

}

private void analyzeLockFileDependencies(Dependency lockFileDependency, Engine engine) throws AnalysisException {
engine.removeDependency(lockFileDependency);

JsonNode rootNode;
File lockFile = lockFileDependency.getActualFile();
ObjectMapper objectMapper = new ObjectMapper(new YAMLFactory());
try {
rootNode = objectMapper.readTree(lockFile);
} catch (IOException e) {
throw new AnalysisException("Problem occurred while reading dependency lockFile.", e);
}

addLockFileDependenciesToEngine(lockFile, engine, rootNode);
}

private void addLockFileDependenciesToEngine(File file, Engine engine, JsonNode rootNode) throws AnalysisException {
for (JsonNode nextPackage : rootNode.get("packages")) {
JsonNode description = nextPackage.get("description");
if (description == null) {
continue;
}

JsonNode nameNode = description.get("name");
if (nameNode == null) {
continue;
}

JsonNode versionNode = nextPackage.get("version");
if (versionNode == null) {
continue;
}

String name = nameNode.asText();
String version = versionNode.asText();
LOGGER.debug("Found dependency in {} file, name: {}, version: {}", LOCK_FILE, name, version);

engine.addDependency(
createDependencyFromNameAndVersion(file, name, version)
);
}
}

private void addYamlDependenciesToEngine(Iterator<Map.Entry<String, JsonNode>> dependencies, File file, Engine engine) throws AnalysisException {
while (dependencies.hasNext()) {
Map.Entry<String, JsonNode> entry = dependencies.next();

String name = entry.getKey();
String versionRaw = entry.getValue().asText();
String version = extractMinimumVersion(versionRaw);
LOGGER.debug("Found dependency in {} file, name: {}, version: {}", YAML_FILE, name, version);

engine.addDependency(
createDependencyFromNameAndVersion(file, name, version)
);
}
}

private Dependency createDependencyFromNameAndVersion(File file, String name, String version) throws AnalysisException {
Dependency dependency = new Dependency(file, true);

// currently not supported by Sonatype OSS
// // dependency.setEcosystem(DEPENDENCY_ECOSYSTEM);
dependency.setName(name);
dependency.setVersion(version);

PackageURL packageURL;
try {
packageURL = PackageURLBuilder
.aPackageURL()
.withType("pub")
.withName(dependency.getName())
.withVersion(version.isEmpty() ? null : version)
.build();

} catch (MalformedPackageURLException e) {
throw new AnalysisException("Problem occurred while reading dependency file.", e);
}

dependency.addSoftwareIdentifier(new PurlIdentifier(packageURL, Confidence.HIGHEST));

dependency.addEvidence(EvidenceType.PRODUCT, file.getName(), "name", name, Confidence.HIGHEST);
dependency.addEvidence(EvidenceType.VENDOR, file.getName(), "name", name, Confidence.HIGHEST);
dependency.addEvidence(EvidenceType.VENDOR, file.getName(), "name", "dart", Confidence.HIGHEST);
if (!version.isEmpty()) {
dependency.addEvidence(EvidenceType.VERSION, file.getName(), "version", version, Confidence.MEDIUM);
}

final String packagePath = String.format("%s:%s", name, version);
dependency.setSha1sum(Checksum.getSHA1Checksum(packagePath));
dependency.setSha256sum(Checksum.getSHA256Checksum(packagePath));
dependency.setMd5sum(Checksum.getMD5Checksum(packagePath));
dependency.setPackagePath(packagePath);
dependency.setDisplayFileName(packagePath);

return dependency;
}

private String extractMinimumVersion(String versionRaw) {
String version;
if (versionRaw.contains("^")) {
version = versionRaw.replace("^", "");
} else if (versionRaw.contains("<")) {
// this code should parse version definitions like ">=2.10.0 <3.0.0"
String firstPart = versionRaw.split("<")[0].trim();
version = firstPart.replace(">=", "").trim();
} else if (versionRaw.contains("any")) {
version = "";
} else {
version = versionRaw;
}

LOGGER.debug("Extracted minimum version: {} from raw version: {}", version, versionRaw);
return version;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ public final class Ecosystem {
*/
public static final String ELIXIR = "exlixir";

/**
* The Dart ecosystem.
*/
public static final String DART = "dart";


/**
* A reference to the ODC settings.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ org.owasp.dependencycheck.analyzer.VersionFilterAnalyzer
org.owasp.dependencycheck.analyzer.OssIndexAnalyzer
org.owasp.dependencycheck.analyzer.PerlCpanfileAnalyzer
org.owasp.dependencycheck.analyzer.PinnedMavenInstallAnalyzer
org.owasp.dependencycheck.analyzer.DartAnalyzer
1 change: 1 addition & 0 deletions core/src/main/resources/dependencycheck.properties
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ analyzer.pe.enabled=true
analyzer.hint.enabled=true
analyzer.nvdcve.enabled=true
analyzer.vulnerabilitysuppression.enabled=true
analyzer.dart.enabled=true
updater.nvdcve.enabled=true
updater.versioncheck.enabled=true
analyzer.versionfilter.enabled=true
Expand Down
Loading