Added new Nuget packages.config analyzer (Nugetconf) #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 25, 2018 00:44
|
Can one of the admins verify this patch? |
This was referenced Jul 31, 2018
|
@doshyt - this is one of the most complete and highest quality PRs we've seen. From clean, documented code to updating the user documentation. Thank you for adding the configuration to all of the implementations (maven, cli, ...). What really surprised me is that you even noticed that you needed to update the dependencycheck-base-suppression.xml to filter out some obvious FP. Thank you! |
|
@jeremylong - thanks for the good words! I also noticed that there is a lot of duplication in XPath parsing implementations between Nuspec, MSBuild and packages.config analyzers. Probably, it can be simplified and merged into the same parser that implements searches for these analyzers. I would love to work on it next. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Adds support of .NET packages.config dependency format. This format is a popular way to declare dependencies for MSBuild projects without including them into *.csproj files or using *.nuspec files.
Description of Change
Created a new analyzer "Nugetconf" using the existing Nuspec and MSBuild analyzers as inspirations; marked it as experimental. Updated settings, CLI options, various documentation files and added test cases.
Have test cases been added to cover the new functionality?
Yes