Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incompatibility with Mobile-Detect v2.8.43 #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunnydavis
Copy link

The problem is caused by the ->is*() function, aka the "Extended" features confusing the core function of detecting mobile devices. I think the better way to fix it is to overwrite the getMobileDetectionRules() and make sure it won't be polluted. In this case the extended features still work while not sacrifice the ability to detect mobile devices.

@francislavoie
Copy link

No longer needed, see #208 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants