Make workflow-api compatible with Guava 21.0 and newer #135
Conversation
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScanner.java
Outdated
Show resolved
Hide resolved
car-roll
changed the title
car-roll
changed the title
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
| @@ -194,7 +198,7 @@ public void onFailure(Throwable t) { | |||
| LOGGER.log(WARNING, "Failed to load " + e, t); | |||
| } | |||
| } | |||
| }); | |||
| }, newExecutorService()); | |||
There was a problem hiding this comment.
Not sure I get it. The original code was not specifying an executor service, so why do we need to add this code now?
There was a problem hiding this comment.
Deprecated in v22 https://github.com/google/guava/blob/v22.0/guava/src/com/google/common/util/concurrent/Futures.java#L1073
Removed in v26
https://github.com/google/guava/blob/v26.0/guava/src/com/google/common/util/concurrent/Futures.java (not there anymore)
There was a problem hiding this comment.
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
| @@ -194,7 +198,7 @@ public void onFailure(Throwable t) { | |||
| LOGGER.log(WARNING, "Failed to load " + e, t); | |||
| } | |||
| } | |||
| }); | |||
| }, newExecutorService()); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Alternatively I think you could take the MoreExecutors and DirectExecutor classes from jenkinsci/workflow-support-plugin#117 and then pass MoreExecutors.directExecutor() without having to use reflection here.
|
release please? ❤️ |
No description provided.