[JENKINS-64438] Implement removeAll on FlowNode actions to support addOrReplaceAction.

src/main/java/org/jenkinsci/plugins/workflow/graph/FlowNode.java

@@ -36,6 +36,7 @@
 import java.io.ObjectStreamException;
 import java.util.AbstractList;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
@@ -463,6 +464,15 @@ public Action set(int index, Action element) {
                 public int size() {
                     return actions.size();
                 }
+
+                @Override
+                public boolean removeAll(Collection<?> c) {
+                    boolean changed = actions.removeAll(c);
+                    if (changed) {
+                        persistSafe();
+                    }
+                    return changed;
+                }
         };
     }
 

src/test/java/org/jenkinsci/plugins/workflow/graph/FlowNodeTest.java

@@ -486,6 +486,15 @@ public void nodeWithNoParentsInBruteForceScanForEnclosingBlock() {
         });
     }
 
+    @Test
+    public void addOrReplaceActionWorks()  {
+        rr.then(r -> {
+            WorkflowJob j = r.createProject(WorkflowJob.class);
+            j.setDefinition(new CpsFlowDefinition("doubleWarning()", true));
+            r.buildAndAssertSuccess(j);
+        });
+    }
+
     private void assertWarning(FlowNode node, Result expectedResult, BallColor expectedColor) {
         WarningAction warningAction = node.getPersistentAction(WarningAction.class);
         assertNotNull(warningAction);
@@ -572,5 +581,36 @@ public Set<? extends Class<?>> getRequiredContext() {
             }
         }
     }
+
+    public static class DoubleWarningStep extends Step {
+
+        @DataBoundConstructor
+        public DoubleWarningStep() {}
+
+        @Override
+        public StepExecution start(StepContext context) throws Exception {
+            return new StepExecution(context) {
+                @Override
+                public boolean start() throws Exception {
+                    getContext().get(FlowNode.class).addAction(new WarningAction(Result.FAILURE).withMessage("First"));
+                    getContext().get(FlowNode.class).addOrReplaceAction(new WarningAction(Result.FAILURE).withMessage("Second"));
+                    getContext().onSuccess(null);
+                    return true;
+                }
+            };
+        }
+        @TestExtension("addOrReplaceActionWorks")
+        public static class DescriptorImpl extends StepDescriptor {
+            @Override
+            public String getFunctionName() {
+                return "doubleWarning";
+            }
+
+            @Override
+            public Set<? extends Class<?>> getRequiredContext() {
+                return Collections.singleton(FlowNode.class);
+            }
+        }
+    }
 }