Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exclusion of spotbugs-annotations from checks-api #1838

Closed
wants to merge 1 commit into from

Conversation

MarkEWaite
Copy link
Contributor

Remove unused exclusion of spotbugs-annotations from checks-api

Current checks-api does not require the exclusion

Testing done

Confirmed that spotbugs-annotations is not included in the plugin packaging.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Current checks-api does not require the exclusion

Confirmed that spotbugs-annotations is not included in the plugin packaging.
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (bcfd383) to head (5a450ac).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1838      +/-   ##
============================================
- Coverage     82.66%   82.57%   -0.10%     
+ Complexity     1362     1360       -2     
============================================
  Files           249      249              
  Lines          5233     5233              
  Branches        402      402              
============================================
- Hits           4326     4321       -5     
- Misses          798      802       +4     
- Partials        109      110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarkEWaite
Copy link
Contributor Author

Closing because I submitted it from the wrong base branch

@MarkEWaite MarkEWaite closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants