Resolve regression where library steps cannot declare a package #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
fixes #296
Description
PR #286 introduced a regression causing library steps that declare a package name to fail to compile.
We switched from setting the step's base script to a
StepWrapperScript
via theCompilerConfiguration
to instead using the@BaseScript
annotation.This annotation was being added to the step source text by prepending the line of code.
It was this prepending that caused the compilation exception, because the package declaration must come first.
The bug is resolved by instead appending the
@BaseScript
annotation to the bottom of the step's source text instead.How Has This Been Tested
unit test confirms bug and fix
Types of Changes
Checklist