Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Environment ignores user configuration for name #258

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Application Environment ignores user configuration for name #258

merged 1 commit into from
Feb 25, 2022

Conversation

steven-terrana
Copy link

PR Details

The ApplicationEnvironment primitive was previously checking the object prior to checking the user provided definition of the application environment in the pipeline configuration.

This meant that for certain fields, such as name, the value would return unexpected results.

fixes #254

Description

Updated the order in which properties on the ApplicationEnvironment class are fetched.
We now first check the pipeline configuration definition and then proceed to the object itself.
If no property is found, we still return null.

How Has This Been Tested

Unit tests.

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

@steven-terrana steven-terrana added the bug Something isn't working label Feb 25, 2022
@steven-terrana steven-terrana merged commit 6480baf into jenkinsci:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: name configuration on Application Environment ignored
1 participant