Application Environment ignores user configuration for name
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
The
ApplicationEnvironment
primitive was previously checking the object prior to checking the user provided definition of the application environment in the pipeline configuration.This meant that for certain fields, such as
name
, the value would return unexpected results.fixes #254
Description
Updated the order in which properties on the
ApplicationEnvironment
class are fetched.We now first check the pipeline configuration definition and then proceed to the object itself.
If no property is found, we still return
null
.How Has This Been Tested
Unit tests.
Types of Changes
Checklist