forked from boozallen/jenkins-templating-engine
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose JTE Primitives via GlobalVariables instead of the TemplateBinding #192
Merged
steven-terrana
merged 16 commits into
jenkinsci:main
from
steven-terrana:global-variables
Apr 5, 2021
Merged
Expose JTE Primitives via GlobalVariables instead of the TemplateBinding #192
steven-terrana
merged 16 commits into
jenkinsci:main
from
steven-terrana:global-variables
Apr 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cokieffebah
reviewed
Apr 1, 2021
src/main/groovy/org/boozallen/plugins/jte/init/primitives/TemplatePrimitive.groovy
Show resolved
Hide resolved
cokieffebah
reviewed
Apr 1, 2021
src/main/groovy/org/boozallen/plugins/jte/init/primitives/TemplatePrimitive.groovy
Show resolved
Hide resolved
cokieffebah
reviewed
Apr 2, 2021
src/main/groovy/org/boozallen/plugins/jte/init/primitives/injectors/Keyword.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/org/boozallen/plugins/jte/init/primitives/injectors/StepWrapperFactory.groovy
Outdated
Show resolved
Hide resolved
cokieffebah
added
the
internal-code-change
A change without user-facing implications
label
Apr 2, 2021
cokieffebah
reviewed
Apr 2, 2021
src/main/groovy/org/boozallen/plugins/jte/init/primitives/TemplatePrimitive.groovy
Show resolved
Hide resolved
cokieffebah
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR hopefully fixes #188 and all cases of
Description
Until now, all JTE Pipeline Primitives like steps, stages, keywords, application_environments were instantiated as objects and stored in a common
TemplateBinding
.This TemplateBinding was needed several times in different contexts and was therefore stored as an
InvisibleAction
.Objects serialized via
Actions
are subject to JEP-200 which meant that we needed to maintain a customClassFilterImpl
.This quickly grew unmanageable as it meant that any user defined variable in the binding would need to be added to the
ClassFilterImpl
.This PR resolves the issue by demoting the role of
TemplateBinding
to that of a runtime collision detector and instead surfacesTemplatePrimitives
via aGlobalVariableSet
.Overall, this was a pretty substantial PR:
Fortunately, the change actually simplified JTE internals a bit.
How Has This Been Tested
Used myself for a week or so. Unit tests continuing to pass.
Types of Changes
Checklist