Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in sandbox for default groovy static methods #177

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Fix bug in sandbox for default groovy static methods #177

merged 4 commits into from
Feb 22, 2021

Conversation

steven-terrana
Copy link

PR Details

Resolves a missed edge case in the sandbox exceptions pertaining to default groovy methods. fixes #170.

How Has This Been Tested

unit tests confirm the fix

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

@steven-terrana steven-terrana added the bug Something isn't working label Feb 22, 2021
@cokieffebah cokieffebah self-requested a review February 22, 2021 22:15
@steven-terrana steven-terrana merged commit 99f53c8 into jenkinsci:main Feb 22, 2021
@steven-terrana steven-terrana deleted the 170 branch April 27, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cokieffebah cokieffebah cokieffebah approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script Approval required
2 participants
@steven-terrana @cokieffebah