Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to Prototype #84

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Remove reference to Prototype #84

merged 2 commits into from
Nov 20, 2023

Conversation

basil
Copy link
Member

@basil basil commented Nov 8, 2023

When running on recent releases of Jenkins core with Prototype removed, a scary-looking but harmless warning (stack trace) is printed to the Jenkins log:

2023-04-04 03:12:57.973+0000 [id=264]        WARNING        o.k.s.f.adjunct.AdjunctsInPage#findNeeded: No such adjunct found: org.kohsuke.stapler.framework.prototype.prototype
org.kohsuke.stapler.framework.adjunct.NoSuchAdjunctException: Neither org.kohsuke.stapler.framework.prototype.prototype.css, .js, .html, nor .jelly were found
        at org.kohsuke.stapler.framework.adjunct.Adjunct.<init>(Adjunct.java:125)
        at org.kohsuke.stapler.framework.adjunct.AdjunctManager.get(AdjunctManager.java:148)
        at org.kohsuke.stapler.framework.adjunct.AdjunctsInPage.findNeeded(AdjunctsInPage.java:161)
        at org.kohsuke.stapler.framework.adjunct.AdjunctsInPage.assumeIncluded(AdjunctsInPage.java:131)
        at org.kohsuke.stapler.framework.adjunct.AdjunctsInPage.assumeIncluded(AdjunctsInPage.java:125)

This PR updates the core baseline to the (forthcoming) LTS release (2.426.x), which removes the harmless warning.

Testing done

Reproduced the warning on a recent weekly, and verified that with this change the warning is no longer printed.

pom.xml Outdated Show resolved Hide resolved
@basil basil added the bugfix label Nov 8, 2023
@basil basil requested review from mtughan and a team November 8, 2023 23:36
@mtughan
Copy link
Contributor

mtughan commented Nov 13, 2023

Thanks @basil. Will try to get to this in the next few days and get it merged shortly.

@mtughan mtughan merged commit 7b33a7e into jenkinsci:main Nov 20, 2023
15 checks passed
@basil basil deleted the prototype branch November 27, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants