Fix icon on dropdown and address EOL JSR 305 from core #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
changed the title
|
Thanks @NotMyFault. Things have been a bit busy for me personally so I haven't gotten a chance to review this yet. I took a preliminary look and it looks good, so I'm hoping to get to it soon. Thanks for your contributions to the plugin! |
|
@NotMyFault, is there a specific reason why we need to push the plugin to 2.332.x instead of 2.319.x? Best I can tell, the specific fix you're targeting to fix occurred in 2.319, so specifying a minimum version of that should be sufficient. |
|
There've been a few test failures on 2.319.x iirc, hence I went ahead to a supported LTS line, because I have no time addressing these. |
|
Gotcha, that makes sense. Thanks for the info. |
mtughan
approved these changes
May 9, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change proposed fixes a broken icon on the dropdown and exchanges JSR 305 with findbugs, because it's been removed from core in newer versions.
to
cc @mtughan