[FIXED JENKINS-37031] tcpSlaveAgentListener should publish supported agent protocols to speed up connection setup #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er connection negotiation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Should be safe for backporting. @stephenc I would kindly ask to create PRs from a fork. Otherwise Jenkins automatic issue updater goes crazy |
|
@reviewbybees done |
| if (names != null) { | ||
| for (String name: names.split(",")) { | ||
| name = name.trim(); | ||
| if (!name.isEmpty()) { |
There was a problem hiding this comment.
Why not just StringUtils.isNotBlank()?
There was a problem hiding this comment.
Because StringUtils is not on the classpath in remoting.jar (which is supposed to be self-contained)
|
Finally there is a 🐛 from what I see. |
|
Change in Jenkins core is unlikely a subject for backporting |
|
🐝 |
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
Aug 14, 2016
Changes are listed below: Fixed issues: * [JENKINS-22853](https://issues.jenkins-ci.org/browse/JENKINS-22853) - Be robust against the delayed EOF command when unexporting input and output streams. (jenkinsci/remoting#97) * Fixed ~20 minor issues reported by FindBugs. More fixes to be delivered in future versions. (jenkinsci/remoting#96) Enhancements: * [JENKINS-37218](https://issues.jenkins-ci.org/browse/JENKINS-37218) - Performance: <code>ClassFilter</code> does not use Regular Expressions anymore to match <code>String.startsWith</code> patterns. (jenkinsci/remoting#92) * [JENKINS-37031](https://issues.jenkins-ci.org/browse/JENKINS-37031) <code>TcpSlaveAgentListener</code> now publishes a list of supported agent protocols to speed up connection setup. (jenkinsci/remoting#93)
DanielWeber
added a commit
to DanielWeber/jenkins
that referenced
this pull request
Aug 26, 2016
(Cherry Pick of 06be933) Changes are listed below: Fixed issues: * [JENKINS-22853](https://issues.jenkins-ci.org/browse/JENKINS-22853) - Be robust against the delayed EOF command when unexporting input and output streams. (jenkinsci/remoting#97) * Fixed ~20 minor issues reported by FindBugs. More fixes to be delivered in future versions. (jenkinsci/remoting#96) Enhancements: * [JENKINS-37218](https://issues.jenkins-ci.org/browse/JENKINS-37218) - Performance: <code>ClassFilter</code> does not use Regular Expressions anymore to match <code>String.startsWith</code> patterns. (jenkinsci/remoting#92) * [JENKINS-37031](https://issues.jenkins-ci.org/browse/JENKINS-37031) <code>TcpSlaveAgentListener</code> now publishes a list of supported agent protocols to speed up connection setup. (jenkinsci/remoting#93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-37031 and jenkinsci/jenkins#2486
@reviewbybees @jenkinsci/code-reviewers